[DI] Fix dumping with custom base class #24954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29ce7be to
c179710
Compare
|
This works when I have a custom container base class but it broke the container without a custom base class: class ApplicationDevDebugProjectContainer extends \Container
|
c179710 to
2dd74ab
Compare
|
@kbond thanks, should be fixed. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 13, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [DI] Fix dumping with custom base class | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24948 | License | MIT | Doc PR | - ping @kbond please confirm it's OK for you Commits ------- 2dd74ab [DI] Fix dumping with custom base class
|
👍 perfect! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @kbond please confirm it's OK for you