Skip to content

[Console] remove dead code #24962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2017
Merged

[Console] remove dead code #24962

merged 1 commit into from
Nov 15, 2017

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Nov 13, 2017

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Part of #24961 for 2.7

@Tobion Tobion mentioned this pull request Nov 13, 2017
Merged
ro0NL
ro0NL approved these changes Nov 14, 2017
View reviewed changes
Copy link
Contributor

@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noise comments removed :) confused with other PR.

@chalasr
Copy link
Member

chalasr commented Nov 15, 2017

Good catch, thanks @Tobion.

@chalasr chalasr merged commit 65f2b13 into symfony:2.7 Nov 15, 2017
chalasr added a commit that referenced this pull request Nov 15, 2017
@chalasr
minor #24962 [Console] remove dead code (Tobion)
2c2253d 
This PR was merged into the 2.7 branch.

Discussion
----------

[Console] remove dead code

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Part of #24961 for 2.7

Commits
-------

65f2b13 [Console] remove dead code
@stof
Copy link
Member

stof commented Nov 17, 2017

This is broken. You are now passing the Error to renderException instead of a FatalThrowableException, and this does not pass the typehint

@stof
Copy link
Member

stof commented Nov 17, 2017

2.7 does not have a typehint, but 3.x does have it.

@chalasr
Copy link
Member

chalasr commented Nov 17, 2017

@stof Error instances are rethrown , the FatalThrowableError instance was never passed to renderException()

@Tobion Tobion deleted the console-dead-code branch November 17, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro0NL ro0NL ro0NL approved these changes

@xabbuh xabbuh xabbuh approved these changes

@20uf 20uf 20uf approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Tobion @chalasr @stof @ro0NL @xabbuh @20uf @carsonbot