[HttpKernel] Fix service arg resolver for controllers as array callables #24970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aren't workshops useful? And yea... this important class doesn't have a test at all yet. Maybe we should add one at lunch tomorrow ;) |
|
@weaverryan Maybe we should keep that kind of contribution (the tests) for the hackday in 3 days ? |
ogizanagi
approved these changes
Nov 15, 2017
|
Created tests for the existing behaviour plus the failing test in here: #24972 |
|
Closing in favor of #24972 |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 16, 2017
…rray callables (sroze, nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Fix service arg resolver for controllers as array callables | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24970 | License | MIT | Doc PR | ø Replacing #24970 as I can't push tests directly to @nicolas-grekas' PR. > As spotted today during a Symfony 4 workshop at SymfonyCon Cluj, setting a controller as an array [SomeController::class, 'helloAction'] works, it is defined as a service, BUT the actions don't get the services as arguments. This is fixing it. Commits ------- fc3d3bb [HttpKernel] Fix service arg resolver for controllers as array callables a9e9f36 Add service value resolver tests Prove that the service value resolver will not work with the array notation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted today during a Symfony 4 workshop at SymfonyCon Cluj, setting a controller as an array
[SomeController::class, 'helloAction']works, it is defined as a service, BUT the actions don't get the services as arguments. This is fixing it.