[DependencyInjection] Single typed argument can be applied on multiple parameters #24991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
189ee28 to
2e11874
Compare
Simperfit
approved these changes
Nov 16, 2017
|
thank you so much @sroze |
|
do you think you coud also include the patch on PassConfig on # #24978, and add a test in ContainerBuilderTest that ensures that named arguments win over bindings? |
2e11874 to
bf7eeef
Compare
|
@nicolas-grekas good point, I've added the test proving the named vs the typed. But I think the priority of the passes should be in another PR, will issue another tomorrow. |
24173cf to
d512654
Compare
|
@nicolas-grekas actually needed this new test fixture class so added the test here as well. It turns out that we don't need the pass order change. |
stof
approved these changes
Nov 17, 2017
|
Thank you @nicolas-grekas & @sroze. |
stof
added a commit
that referenced
this pull request
Nov 17, 2017
… on multiple parameters (nicolas-grekas, sroze) This PR was merged into the 3.4 branch. Discussion ---------- [DependencyInjection] Single typed argument can be applied on multiple parameters | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø I'm @nicolas-grekas' test writer today. This makes the argument resolution working when injecting the same type multiple times (sub-set of PR #24978) Commits ------- d512654 Test that named arguments are prioritized over typehinted bf7eeef Prove that change is working with tests 2176be7 [DI] Fix by-type args injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm @nicolas-grekas' test writer today. This makes the argument resolution working when injecting the same type multiple times (sub-set of PR #24978)