Allow EnumNode name to be null #25048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MatTheCat
commented
Nov 20, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25046 |
| License | MIT |
|
Thanks, could you add a test case please? |
|
Yep, guess 74b9fb1 will be enough? |
xabbuh
approved these changes
Nov 20, 2017
chalasr
reviewed
Nov 20, 2017
| @@ -43,6 +43,11 @@ public function testConstructionWithOneDistinctValue() | |||
| $this->assertSame('foo', $node->finalize('foo')); | |||
| } | |||
|
|
|||
| public function testConstructionWithNullName() | |||
| { | |||
| new EnumNode(null, null, array('foo')); | |||
There was a problem hiding this comment.
please call ->finalize() or so to make the test not risky
chalasr
reviewed
Nov 20, 2017
| public function testConstructionWithNullName() | ||
| { | ||
| $node = new EnumNode(null, null, array('foo')); | ||
| $node->finalize('foo'); |
There was a problem hiding this comment.
please assert it (sorry I've been unclear) :)
|
Woops sorry 😓 |
chalasr
approved these changes
Nov 20, 2017
stof
approved these changes
Nov 20, 2017
ogizanagi
approved these changes
Nov 20, 2017
|
Thank you @MatTheCat. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2017
This PR was squashed before being merged into the 4.0-dev branch (closes #25048). Discussion ---------- Allow EnumNode name to be null | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25046 | License | MIT Commits ------- 57d0636 Allow EnumNode name to be null
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.