[HttpKernel] Disable container inlining when legacy inlining has been used #25082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 21, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25059 |
| License | MIT |
| Doc PR | - |
aeb76ec to
8629838
Compare
ogizanagi
reviewed
Nov 21, 2017
| @@ -812,13 +812,17 @@ protected function dumpContainer(ConfigCache $cache, ContainerBuilder $container | |||
| $dumper->setProxyDumper(new ProxyDumper(substr(hash('sha256', $cache->getPath()), 0, 7))); | |||
| } | |||
|
|
|||
| if ($this->loadClassCache || class_exists(ClassCollectionLoader::class, false)) { | |||
| // if legacy inlining has been used, disable container inlining | |||
| $container->getParameter('container.dumper.inline_class_loader', false); | |||
There was a problem hiding this comment.
- getParameter
+ setParameter? But that's a FrozenParameterBag here
There was a problem hiding this comment.
good catch, should be better now
8629838 to
4a11683
Compare
fabpot
approved these changes
Nov 21, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 21, 2017
…ng has been used (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Disable container inlining when legacy inlining has been used | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25059 | License | MIT | Doc PR | - Commits ------- 4a11683 [HttpKernel] Disable container inlining when legacy inlining has been used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.