[FrameworkBundle][DX] Display a nice error message if an enabled component is missing #25094
Conversation
derrabus
commented
Nov 21, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25093 |
| License | MIT |
| Doc PR | N/A |
|
Could you please check if that happens for other components also? |
| @@ -232,6 +232,10 @@ public function load(array $configs, ContainerBuilder $container) | |||
| } | |||
|
|
|||
| if ($this->isConfigEnabled($container, $config['form'])) { | |||
| if (!class_exists('Symfony\Component\Form\Form')) { | |||
| throw new LogicException('Form support cannot be enabled. Please install the Form component.'); | |||
There was a problem hiding this comment.
just to match similar messages:
Form support cannot be enabled as the Form component is not installed.
|
For other components we did this in 3.3. Should we merge the PR into the |
|
@nicolas-grekas Serializer is also affected. I can enable the component without having it installed and FrameworkBundle would register the |
|
I've also checked the validator: When enabling it, |
4b86116 to
e31badc
Compare
|
Do you think, we can remove those lines? Installing Validator without Translation is not possible, enabling validation without the Validator component will be caught elsewhere. So this block just generates a confusing error message. |
e31badc to
127b9de
Compare
127b9de to
2b45805
Compare
|
3.3 it is, then. |
|
Thank you @derrabus. |
…nabled component is missing (derrabus) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle][DX] Display a nice error message if an enabled component is missing | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25093 | License | MIT | Doc PR | N/A Commits ------- 2b45805 Display a nice error message if the form/serializer component is missing.
|
@derrabus about #25094 (comment), you reverted your idea? |
|
@nicolas-grekas For now, yes. That change conflicted with the 3.3 branch. I will setup a 3.3 app tonight and test again. |