[Form] Fixed ContextErrorException in FileType #25102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Nov 22, 2017
|
|
||
| foreach ($event->getData() as $file) { | ||
| if (!is_array($files)) { |
There was a problem hiding this comment.
What about checking for null here first and then dropping everything afterwards that is not an array?
There was a problem hiding this comment.
or maybe just:
if (!is_array($files)) {
$files = array(null);
}There was a problem hiding this comment.
@xabbuh Thank you, I fixed it.
xabbuh
approved these changes
Nov 23, 2017
issei-m
reviewed
Nov 23, 2017
|
|
||
| foreach ($event->getData() as $file) { | ||
| if (!is_array($files)) { | ||
| $files = array(null); |
There was a problem hiding this comment.
$files = array(); also looks more better to me, it reduces the redundant traverse over them and RequestHandlerInterface::isFileUpload() method call.
nicolas-grekas
approved these changes
Nov 23, 2017
|
Thank you @chihiro-adachi. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 23, 2017
…achi) This PR was squashed before being merged into the 2.7 branch (closes #25102). Discussion ---------- [Form] Fixed ContextErrorException in FileType | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25063 | License | MIT | Doc PR | -- Fixed an issue that ContextErrorException occurs when multiple is enabled. Commits ------- 1b408e6 [Form] Fixed ContextErrorException in FileType
This was referenced Dec 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue that ContextErrorException occurs when multiple is enabled.