Make debug:container search command case-insensitive #25109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#25107 is related to search not detecting the characters after the \. It is not an uppercase problem. |
|
@Vinorcola it is actually the same issue - in FQCN letter after backslash is uppercase and that's the reason why it's not searchable - if you would create class starting with lower letter it would work correctly |
|
@jzawadzki Ok, great ;) |
|
@jzawadzki could you please rebase on 3.3? 3.2 is not maintained anymore (I already changed the base branch here on github). |
9a801b8 to
c429c33
Compare
|
@nicolas-grekas done! |
nicolas-grekas
approved these changes
Nov 23, 2017
fabpot
approved these changes
Nov 23, 2017
|
Thank you @jzawadzki. |
fabpot
added a commit
that referenced
this pull request
Nov 23, 2017
…adzki) This PR was merged into the 3.3 branch. Discussion ---------- Make debug:container search command case-insensitive | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #25107 | License | MIT | Doc PR | This bug fixes the #25107 - starts from 3.2 services may be written with uppercase (e.g. FQCN) and search fails to match those services. Commits ------- c429c33 Make search in debug:container command case-insensitive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fixes the #25107 - starts from 3.2 services may be written with uppercase (e.g. FQCN) and search fails to match those services.