Skip to content

[SecurityBundle][Security][Translation] trigger some deprecations for legacy methods #25131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2017
Merged

[SecurityBundle][Security][Translation] trigger some deprecations for legacy methods #25131

merged 1 commit into from
Nov 26, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 23, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.1 milestone Nov 23, 2017
chalasr
chalasr reviewed Nov 23, 2017
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to deprecate the logout_on_user_change firewall config node

src/Symfony/Component/Translation/Writer/TranslationWriter.php
@@ -41,7 +41,8 @@ public function addDumper($format, DumperInterface $dumper)
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deprecated annotations are missing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

hhamon
hhamon reviewed Nov 23, 2017
View reviewed changes
src/Symfony/Component/Security/Http/Firewall/ContextListener.php Outdated
@@ -70,7 +70,7 @@ public function __construct(TokenStorageInterface $tokenStorage, iterable $userP
*/
public function setLogoutOnUserChange($logoutOnUserChange)
{
// no-op, method to be deprecated in 4.1
@trigger_error(sprintf('The %s() method is deprecated since 4.1 and will be removed in 5.0.', __METHOD__));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing E_USER_DEPRECATED error level.

hhamon
hhamon reviewed Nov 23, 2017
View reviewed changes
src/Symfony/Component/Translation/Dumper/FileDumper.php Outdated
@@ -49,12 +49,11 @@ public function setRelativePathTemplate($relativePathTemplate)
*/
public function setBackup($backup)
{
@trigger_error(sprintf('The %s() method is deprecated since 4.1 and will be removed in 5.0.', __METHOD__));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing E_USER_DEPRECATED error level.

hhamon
hhamon reviewed Nov 23, 2017
View reviewed changes
src/Symfony/Component/Translation/Writer/TranslationWriter.php Outdated
@@ -41,7 +41,8 @@ public function addDumper($format, DumperInterface $dumper)
*/
public function disableBackup()
{
// to be deprecated in 4.1
@trigger_error(sprintf('The %s() method is deprecated since 4.1 and will be removed in 5.0.', __METHOD__));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing E_USER_DEPRECATED error level.

@xabbuh xabbuh force-pushed the deprecations branch 2 times, most recently from 600c817 to 3909cc4 Compare November 23, 2017 11:10
@xabbuh xabbuh changed the title [Security][Translation] trigger some deprecations for legacy methods [SecurityBundle][Security][Translation] trigger some deprecations for legacy methods Nov 23, 2017
@xabbuh xabbuh force-pushed the deprecations branch 2 times, most recently from f823881 to 7b209e1 Compare November 23, 2017 11:43
@xabbuh
Copy link
Member Author

xabbuh commented Nov 23, 2017

comments addressed, tests pass

chalasr
chalasr approved these changes Nov 23, 2017
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fabpot
fabpot requested changes Nov 23, 2017
View reviewed changes
UPGRADE-4.1.md Outdated
Security
--------

* the `ContextListener::setLogoutOnUserChange()` method is deprecated and will be removed in 5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing cap and dot (same below) and in other files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

src/Symfony/Component/Translation/Writer/TranslationWriter.php
@@ -41,7 +41,8 @@ public function addDumper($format, DumperInterface $dumper)
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@chalasr
Copy link
Member

chalasr commented Nov 26, 2017

Thank you @xabbuh.

@chalasr chalasr merged commit e3396ea into symfony:master Nov 26, 2017
chalasr pushed a commit that referenced this pull request Nov 26, 2017
feature #25131 [SecurityBundle][Security][Translation] trigger some d…
eb8e2d3 
…eprecations for legacy methods (xabbuh)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[SecurityBundle][Security][Translation] trigger some deprecations for legacy methods

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

e3396ea trigger some deprecations for legacy methods
@xabbuh xabbuh deleted the deprecations branch November 26, 2017 13:25
@fabpot fabpot mentioned this pull request May 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhamon hhamon hhamon left review comments

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Deprecation Security Status: Reviewed Translation
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @chalasr @fabpot @hhamon @carsonbot