[Process] Create a "isTtySupported" static method #25142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding a new public method is a new feature. So this cannot go in 2.7 |
|
OK! Would you like me to create a new PR for the master branch? |
|
You can change the target branch on this PR and rebase accordingly. |
c3b9b13 to
a1398f6
Compare
|
The target branch has been changed and the rebase too. |
fabpot
approved these changes
Dec 1, 2017
|
Thank you @nesk. |
fabpot
added a commit
that referenced
this pull request
Dec 7, 2017
This PR was merged into the 4.1-dev branch. Discussion ---------- [Process] Create a "isTtySupported" static method | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | _none_ | License | MIT | Doc PR | _none_ Currently, there is no way to enable the TTY mode without risking an exception. This PR extracts the code checking for TTY support and provides it in a `isTtySupported` static method. Now we can enable the TTY mode everywhere it's available without risking an exception: ```php $process = (new Process)->setTty(Process::isTtySupported()); ``` _Old comment_: > I'm targeting the 2.7 branch since this is not really a new feature, just a little refactoring of the existent code, and it is fully backward compatible. Commits ------- a1398f6 Create a "isTtySupported" static method
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to enable the TTY mode without risking an exception. This PR extracts the code checking for TTY support and provides it in a
isTtySupportedstatic method.Now we can enable the TTY mode everywhere it's available without risking an exception:
Old comment: