[FrameworkBundle] Automatically enable the CSRF protection if CSRF manager exists #25151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Nov 24, 2017
nicolas-grekas
approved these changes
Nov 24, 2017
chalasr
approved these changes
Nov 24, 2017
|
Travis failure is not related :) |
|
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2017
… if CSRF manager exists (sroze) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Automatically enable the CSRF protection if CSRF manager exists | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT This will automatically enable the CSRF protection if `CsrfTokenManagerInterface` exists. Commits ------- fd43406 Automatically enable the CSRF protection if CSRF manager exists
fabpot
added a commit
that referenced
this pull request
Dec 14, 2017
This PR was merged into the 3.4 branch. Discussion ---------- Fixing wrong class_exists on interface | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | symfony/symfony-docs#8873 already does not mention changing anything in the config This was a bug introduced in #25151 on the 3.4 branch. It's... pretty self-explanatory I hope :). Cheers! Commits ------- be75bd9 Fixing wrong class_exists on interface
|
Is this really a good idea? |
|
Auto-enabling CSRF without it working because session are not enabled, sounds like a bad DX
How about only enabling it when session is enabled as well? Or even better, we implement #13464 |
|
I'm going to revert this change as it was broken anyway before the fix today, so it never worked. That will give us some time to implement it properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically enable the CSRF protection if
CsrfTokenManagerInterfaceexists.