[WebProfilerBundle] Expose dotenv variables #25166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like that idea 👍 |
|
3.4 is bugfix only now |
nicolas-grekas
approved these changes
Nov 27, 2017
|
@nicolas-grekas why did you approve it then? 😛 |
|
To let others resolve this :) |
|
@ro0NL Looks like we need a rebase now. :) |
|
@ro0NL Can you rebase on current master? |
|
Done. Perhaps both h4 headings added need some thought for better naming. |
fabpot
added a commit
that referenced
this pull request
Dec 1, 2017
…(ro0NL) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Rename getDotEnvVars to getDotenvVars | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> For consistency with #25166 :) Commits ------- de137d2 [FrameworkBundle] Rename getDotEnvVars to getDotenvVars
fabpot
reviewed
Dec 1, 2017
| @@ -167,7 +167,15 @@ | |||
| {% endif %} | |||
|
|
|||
| <h3>Server Parameters</h3> | |||
| {{ include('@WebProfiler/Profiler/bag.html.twig', { bag: collector.requestserver }, with_context = false) }} | |||
| <h4>Managed by Symfony Dotenv</h4> | |||
There was a problem hiding this comment.
Lets go from there yes. Now updated.
fabpot
reviewed
Dec 1, 2017
| <h4>Managed by Symfony Dotenv</h4> | ||
| {{ include('@WebProfiler/Profiler/bag.html.twig', { bag: collector.dotenvvars }, with_context = false) }} | ||
|
|
||
| <h4>Standard variables</h4> |
There was a problem hiding this comment.
Defined as regular env variables?
fabpot
approved these changes
Dec 1, 2017
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Dec 1, 2017
This PR was squashed before being merged into the 4.1-dev branch (closes #25166). Discussion ---------- [WebProfilerBundle] Expose dotenv variables | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | #23951 | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Variant of #23951  Commits ------- de33d87 [WebProfilerBundle] Expose dotenv variables
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variant of #23951