[HttpKernel] Fix issue when resetting DumpDataCollector #25226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 30, 2017
xabbuh
approved these changes
Nov 30, 2017
ogizanagi
approved these changes
Dec 1, 2017
|
Thank you @Pierstoval. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2017
…ierstoval) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Fix issue when resetting DumpDataCollector | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Fixes issue when resetting the collector and no stopwatch was provided in the constructor. By the way, current workaround is to `composer require symfony/stopwatch`, so this is not a "big blocker". Commits ------- 159fedc [HttpKernel] Fix issue when resetting DumpDataCollector
|
That looks weird anyway. The DumpDataCollector is not collecting stuff from the Stopwatch. It uses it to profile itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue when resetting the collector and no stopwatch was provided in the constructor.
By the way, current workaround is to
composer require symfony/stopwatch, so this is not a "big blocker".