[DI] Fix false-positive circular exception #25247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Dec 1, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25240 |
| License | MIT |
| Doc PR | - |
120d83e to
adf1819
Compare
|
With this my 3.4 build would have been red too, right? Or can i reset my "fix" (set the second service to public) now? |
|
yes, you can revert your fix |
fabpot
approved these changes
Dec 1, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 1, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix false-positive circular exception | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25240 | License | MIT | Doc PR | - Commits ------- adf1819 [DI] Fix false-positive circular exception
|
Thanks @nicolas-grekas |
stof
reviewed
Dec 1, 2017
| { | ||
| $a = ${($_ = isset($this->services['foo5']) ? $this->services['foo5'] : $this->getFoo5Service()) && false ?: '_'}; | ||
|
|
||
| if (isset($this->services['bar5'])) { |
There was a problem hiding this comment.
shouldn't this come first, before defining the $a variable ?
There was a problem hiding this comment.
ah no, understand. This is the call to $this->getFoo5Service() which can register it in $this->services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.