[DI] Allow for invokable event listeners #25275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
approved these changes
Dec 3, 2017
|
I will use this one ! |
Tobion
reviewed
Dec 4, 2017
| @@ -68,6 +68,10 @@ public function process(ContainerBuilder $container) | |||
| '/[^a-z0-9]/i', | |||
| ), function ($matches) { return strtoupper($matches[0]); }, $event['event']); | |||
There was a problem hiding this comment.
I didn't know there is such magic default logic.
There was a problem hiding this comment.
true, yet convenient enough to keep IMHO, or at least didnt want to spoil this feat. along with a deprecation.
Tobion
reviewed
Dec 4, 2017
| public function testInvokableEventListener() | ||
| { | ||
| $container = new ContainerBuilder(); | ||
| $container->register('foo', 'stdClass')->addTag('kernel.event_listener', array('event' => 'foo.bar')); |
| @@ -68,6 +68,10 @@ public function process(ContainerBuilder $container) | |||
| '/[^a-z0-9]/i', | |||
| ), function ($matches) { return strtoupper($matches[0]); }, $event['event']); | |||
| $event['method'] = preg_replace('/[^a-z0-9]/i', '', $event['method']); | |||
|
|
|||
| if (null !== ($class = $container->getDefinition($id)->getClass()) && !method_exists($class, $event['method']) && method_exists($class, '__invoke')) { | |||
There was a problem hiding this comment.
we should use $container->getReflectionClass() instead
this will fix the current logic that misses resource tracking
Taluu
approved these changes
Dec 4, 2017
|
I'm "-0": I don't see the benefit of this. Naming methods helps the reader, and is not a strong requirement. |
naming classes too :) this allows me, the class author, to write IMHO pure event listeners and let users configure as usual. That is win-win. |
chalasr
approved these changes
Dec 29, 2017
xabbuh
approved these changes
Jan 1, 2018
20uf
approved these changes
Jan 11, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jan 19, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- [DI] Allow for invokable event listeners | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Inspired by #24637 / #25259. This adds invokable support for event listeners :) ```yaml Some\Foo: tags: [{ name: kernel.event_listener, event: kernel.request }] ``` ```php class Foo { public function __invoke(GetResponseEvent $event) { } } ``` Commits ------- fa5b7eb [DI] Allow for invokable event listeners
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #24637 / #25259. This adds invokable support for event listeners :)