[FrameworkBundle] Fix a bug where a color tag will be shown when passing an antislash #25308
Conversation
| @@ -226,6 +226,9 @@ protected function describeContainerServices(ContainerBuilder $builder, array $o | |||
| $rawOutput = isset($options['raw_text']) && $options['raw_text']; | |||
| foreach ($this->sortServiceIds($serviceIds) as $serviceId) { | |||
| $definition = $this->resolveServiceDefinition($builder, $serviceId); | |||
| if ('\\' === substr($serviceId, -1)) { | |||
| $serviceId = substr($serviceId, 0, -1); | |||
There was a problem hiding this comment.
But this means that the displayed service ID will be wrong, doesn't it?
There was a problem hiding this comment.
Yeah, you are right, we should escape without removing it. I was not thinking about that, it feels strange to have that kind of service, maybe we should do something before displaying it ?
There was a problem hiding this comment.
I think you need to take a look at the OutputFormatter::escape() method
There was a problem hiding this comment.
Thanks @xabbuh that's what I needed!
987fbae to
a9dbec8
Compare
a9dbec8 to
890edf7
Compare
|
I'm removing the photo from the description, it's a bit weird to see your face when reviewing the PR :) |
|
@nicolas-grekas it's for 3.3 since the bug does not exist before. |
|
Thank you @Simperfit. |
…n when passing an antislash (Simperfit) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle] Fix a bug where a color tag will be shown when passing an antislash | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25193 | License | MIT | Doc PR | none You can see in the [reproducer](Simperfit/symfony-reproducer@e6509ff) when running `bin/console debug:container` that there an error in the ouput (like in the issue) when using a class with `\` in the service name. This PR fix this wrong output. (even if that feels more developer thingy when there are xml everywhere ;) Commits ------- 890edf7 [FrameworkBundle] Fix a bug where a color tag will be shown when passing an antislash
You can see in the reproducer when running
bin/console debug:containerthat there an error in the ouput (like in the issue) when using a class with\in the service name.This PR fix this wrong output. (even if that feels more developer thingy when there are xml everywhere ;)