[ExpressionLanguage] throw an SyntaxError instead of an undefined index notice #25323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99b4086 to
8822114
Compare
xabbuh
reviewed
Dec 7, 2017
| @@ -56,6 +56,10 @@ public function next() | |||
|
|
|||
| ++$this->position; | |||
|
|
|||
| if (!isset($this->tokens[$this->position])) { | |||
| throw new SyntaxError('Unexpected end of expression', $this->current->cursor, $this->expression); | |||
There was a problem hiding this comment.
Shouldn't we move the safe guard that was already there? I don't see how the first exception could ever be thrown. It looks to me like this was just mistakenly placed before the pointer is advanced.
8822114 to
78abc89
Compare
xabbuh
approved these changes
Dec 7, 2017
fabpot
approved these changes
Dec 7, 2017
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Dec 7, 2017
…defined index notice (Simperfit) This PR was merged into the 2.7 branch. Discussion ---------- [ExpressionLanguage] throw an SyntaxError instead of an undefined index notice | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #25214 | License | MIT | Doc PR | none I think this is a bug when the components throws a notice instead of an exception. it's too early and too dark to see something outside so here is my couch :  Commits ------- 78abc89 [ExpressionLanguage] throw an SyntaxError instead of letting a undefined index notice
This was referenced Jan 5, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a bug when the components throws a notice instead of an exception.
it's too early and too dark to see something outside so here is my couch :
