-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpKernel] Enhance exception message for services not found in dedicated service locators #25367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -150,7 +163,7 @@ private function handleRaw(Request $request, $type = self::MASTER_REQUEST) | |||
$arguments = $event->getArguments(); | |||
|
|||
// call controller | |||
$response = call_user_func_array($controller, $arguments); | |||
$response = \call_user_func_array($controller, $arguments); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improves perf, and DX, by removing one noisy frame in exception traces
…cated service locators
f4d93e2
to
2e22748
Compare
I like the detection and how it works out, yet I'm not really sure it solves the DX issue we ran into at #25342. I mean - the guy just followed the tutorial, derived from
And I have no clue how to do this one better either, so I'm also hoping @weaverryan has a brilliant idea on this 😉 |
Don't forget that the goal of the message is not to provide full documentation, but mostly to accurately hint into the right direction. |
Oh, and the second part of your comment, about the context, will be fixed on 4.1, once we will hide by default stack frames in vendor (and keep the one from src/ visible.) |
Closing as I'm working on a more local approach. |
Misses tests for now.
@weaverryan I may need your help to make the message better if you have any suggestions :)