[Debug] Fix catching fatal errors in case of nested error handlers #25408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f47db2 to
34749e6
Compare
4414ce0 to
6215d71
Compare
Simperfit
approved these changes
Dec 9, 2017
0c9fc0d to
20aa35a
Compare
|
I confirm fix works in Symfony 4.0. However, reproducer I posted in #8703 does not work in Symfony 2.7 project. Also I really think there should be a test for this, since this went under radar for so long. edit: thank you for adding tests |
4bb950d to
e18092f
Compare
e18092f to
27dc9a6
Compare
|
Now with tests and green. |
fabpot
approved these changes
Dec 11, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2017
…handlers (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug] Fix catching fatal errors in case of nested error handlers | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8703, #16980 | License | MIT | Doc PR | - Fixing a bug from 2013 :) Commits ------- 27dc9a6 [Debug] Fix catching fatal errors in case of nested error handlers
This was referenced Jan 5, 2018
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Jan 18, 2018
…l with fatal errors (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug] Always decorate existing exception handlers to deal with fatal errors | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25827 | License | MIT | Doc PR | - Decorating the exception is seamless, let's always do it and fix handling of fatal errors. Related to #25408 also. Commits ------- 205d7ae [Debug] Always decorate existing exception handlers to deal with fatal errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug from 2013 :)