[FrameworkBundle] add email_validation_mode option #25478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 13, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
This makes it possible to configure the default validation mode for the email validator according to the changes made in #24442. |
|
Cool. Then I propose to patch the recipe for 4.1 and turn html5 on by default there. |
xabbuh
commented
Dec 13, 2017
| @@ -199,6 +199,8 @@ | |||
| <xsd:attribute name="cache" type="xsd:string" /> | |||
| <xsd:attribute name="enable-annotations" type="xsd:boolean" /> | |||
| <xsd:attribute name="static-method" type="xsd:boolean" /> | |||
| <xsd:attribute name="strict-email" type="xsd:boolean" /> | |||
There was a problem hiding this comment.
This option must also be added in older versions too (see #25480).
0247ef0 to
0adec76
Compare
fabpot
approved these changes
Dec 14, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Dec 14, 2017
…bbuh) This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] add email_validation_mode option | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- cda5825 add email_validation_mode option
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.