[Validator] Add option to pass custom values to Expression validator #25504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5ca7f2 to
e98b8da
Compare
| @@ -30,6 +30,7 @@ class Expression extends Constraint | |||
|
|
|||
| public $message = 'This value is not valid.'; | |||
| public $expression; | |||
| public $values = array(); | |||
There was a problem hiding this comment.
should it be named $variables?
There was a problem hiding this comment.
I've named it according to second argument in ExpressionLanguage::evaluate. If $variables is better name, maybe it's worth it to change it there too? What do you guys think?
1b489fc to
57d79b2
Compare
|
Ping. Values or variables? Will change in ExpressionLanguage accordingly. Vote by reacting with: |
|
I'm good with values also. Any other opinion? |
57d79b2 to
ba0565e
Compare
|
Rebased. More options for naming :
Vote by reacting with: 👍: variables |
nicolas-grekas
approved these changes
Jan 7, 2018
fabpot
approved these changes
Jan 8, 2018
|
Thank you @ostrolucky. |
fabpot
added a commit
that referenced
this pull request
Jan 8, 2018
…sion validator (ostrolucky) This PR was merged into the 4.1-dev branch. Discussion ---------- [Validator] Add option to pass custom values to Expression validator | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I needed this in a Form. I had no way to pass things from `$options` into Expression validator. Maybe can aid in #23134 Commits ------- ba0565e [Validator] Add option to pass custom values to Expression validator
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this in a Form. I had no way to pass things from
$optionsinto Expression validator.Maybe can aid in #23134