[Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions #25559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Dec 20, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25511 |
| License | MIT |
| Doc PR | - |
…le breaks accros PHP versions
0e4347f to
0d4bce6
Compare
stof
approved these changes
Dec 20, 2017
xabbuh
approved these changes
Dec 20, 2017
|
thanks @nicolas-grekas! fixes the issue in our project, just tested it 👍 |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 20, 2017
…roduce subtle breaks accros PHP versions (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25511 | License | MIT | Doc PR | - Commits ------- 0d4bce6 [Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions
|
this bug also occurs in 3.4 |
|
@WPPD 3.3 will be merged into 3.4 if not already the case, so all upper branches will get the fix before next release. |
|
The fix is not merged yet. Is there any workaround applicable? |
|
@n-sviridenko In the meantime it seems to have been merged up to |
This was referenced Jan 5, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.