Skip to content

allow autowire for http_utils class #25562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Conversation

do-see
Copy link
Contributor

@do-see do-see commented Dec 20, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR n.a.

This PR enables autowire for Symfony\Component\Security\Http\HttpUtils.
We use this for an custom authenticator.

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Dec 20, 2017
@sroze
Copy link
Contributor

sroze commented Dec 20, 2017

Thank you for your first contribution @do-see :)

@chalasr
Copy link
Member

chalasr commented Dec 20, 2017

Thank you for this first contribution @do-see, congratz!

@chalasr chalasr merged commit b1030d7 into symfony:master Dec 20, 2017
chalasr pushed a commit that referenced this pull request Dec 20, 2017
This PR was merged into the 4.1-dev branch.

Discussion
----------

allow autowire for http_utils class

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | n.a.

This PR enables autowire for `Symfony\Component\Security\Http\HttpUtils`.
We use this for an custom authenticator.

Commits
-------

b1030d7 allow autowire for http_utils class
@do-see do-see deleted the autowire_http_utils branch December 20, 2017 22:14
lyrixx pushed a commit to lyrixx/symfony that referenced this pull request Dec 29, 2017
This PR was merged into the 4.1-dev branch.

Discussion
----------

allow autowire for http_utils class

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | n.a.

This PR enables autowire for `Symfony\Component\Security\Http\HttpUtils`.
We use this for an custom authenticator.

Commits
-------

b1030d7 allow autowire for http_utils class
@fabpot fabpot mentioned this pull request May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants