Skip to content

[HttpKernel] fix cleaning legacy containers #25591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2017

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

The suffix used to be .legacyContainer (length=16) but we forgot to update the length when it was changed to .legacy (length=7).

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test case would be nice :)

@nicolas-grekas
Copy link
Member Author

now tested

@nicolas-grekas nicolas-grekas changed the title [HttkKernel] fix cleaning legacy containers [HttpKernel] fix cleaning legacy containers Dec 28, 2017
@nicolas-grekas nicolas-grekas merged commit 324821d into symfony:3.4 Dec 28, 2017
nicolas-grekas added a commit that referenced this pull request Dec 28, 2017
This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] fix cleaning legacy containers

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

The suffix used to be `.legacyContainer` (length=16) but we forgot to update the length when it was changed to `.legacy` (length=7).

Commits
-------

324821d [HttpKernel] fix cleaning legacy containers
@nicolas-grekas nicolas-grekas deleted the kernel-clean branch December 28, 2017 11:12
This was referenced Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants