[Process] Make PhpExecutableFinder look for the PHP_BINARY env var
#25629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thanks. Sorry I couldn't find the time to fix it myself. |
fabpot
approved these changes
Dec 31, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 31, 2017
…_BINARY` env var (nicolas-grekas) This PR was merged into the 4.1-dev branch. Discussion ---------- [Process] Make `PhpExecutableFinder` look for the `PHP_BINARY` env var | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22101 | License | MIT | Doc PR | - I think this is enough to fix the linked issue and thus replace #23721. ping @tomasfejfar FYI Commits ------- 4bd01f2 [Process] Make `PhpExecutableFinder` look for the `PHP_BINARY` env var
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is enough to fix the linked issue and thus replace #23721.
ping @tomasfejfar FYI