[FrameworkBundle] Fix using "annotations.cached_reader" in after-removing passes #25696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f4c554 to
f66f9a7
Compare
fabpot
approved these changes
Jan 8, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 8, 2018
… after-removing passes (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle] Fix using "annotations.cached_reader" in after-removing passes | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25695 | License | MIT | Doc PR | - When `annotation_reader` is instantiated in an after-removing pass, it gets the real cache provider, instead of the dummy one that should be provided during compilation of the container. This situation is found in e.g. `JMS\AopBundle\DependencyInjection\Compiler\PointcutMatchingPass`. A workaround before next release could be to "get" the `annotation_reader` service somewhere before (like in a regular compiler pass of your own.) Commits ------- f66f9a7 [FrameworkBundle] Fix using "annotations.cached_reader" in after-removing passes
This was referenced Jan 29, 2018
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Feb 10, 2021
…he "container.hot_path" (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] fix registering "annotations.cache" on the "container.hot_path" | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Because `annotations.cache` is registered in a quite special way (see #25696), `ResolveHotPathPass` cannot propagate the `container.hot_path` tag to it. Let's add the tag explicitly since this service is always on the hot path anyway. Spotted with Blackfire.io as usual. Commits ------- e196c1e [FrameworkBundle] fix registering "annotations.cache" on the "container.hot_path"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
annotation_readeris instantiated in an after-removing pass, it gets the real cache provider, instead of the dummy one that should be provided during compilation of the container.This situation is found in e.g.
JMS\AopBundle\DependencyInjection\Compiler\PointcutMatchingPass.A workaround before next release could be to "get" the
annotation_readerservice somewhere before (like in a regular compiler pass of your own.)