[FrameworkBundle] add autowiring aliases for TranslationReaderInterface, ExtractorInterface & TranslationWriterInterface #25701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already merged similar changes as features and others as bug fixes on 3.4. What should be the rule? I think it's fine as a bug fix. |
nicolas-grekas
approved these changes
Jan 6, 2018
chalasr
approved these changes
Jan 6, 2018
|
Thank you @Nijusan. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 7, 2018
…onReaderInterface, ExtractorInterface & TranslationWriterInterface (Dennis Langen) This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] add autowiring aliases for TranslationReaderInterface, ExtractorInterface & TranslationWriterInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25679 | License | MIT | Doc PR | Supporting #25679 Commits ------- e2ddc17 adding interface alias for reader, writer and extractor
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting #25679