[FrameworkBundle] add cache.app.simple psr simple cache #25710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,10 @@ | |||
| <tag name="cache.pool" clearer="cache.app_clearer" reset="reset" /> | |||
| </service> | |||
|
|
|||
| <service id="cache.app.simple" class="Symfony\Component\Cache\Simple\Psr6Cache" public="true"> | |||
There was a problem hiding this comment.
I just kept it consistent with the cache.app service which is also public.
So not sure 😊
If we don't really promote this service via the documentation I guess we could also make it private.
weaverryan
approved these changes
Jan 7, 2018
xabbuh
approved these changes
Jan 8, 2018
fabpot
approved these changes
Jan 8, 2018
|
Thank you @dmaicher. |
fabpot
added a commit
that referenced
this pull request
Jan 8, 2018
…e (dmaicher) This PR was squashed before being merged into the 4.1-dev branch (closes #25710). Discussion ---------- [FrameworkBundle] add cache.app.simple psr simple cache | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25708 | License | MIT | Doc PR | TODO? This adds a PSR SimpleCache version of the `cache.app` service. Should I also update the documentation somewhere? 😊 Commits ------- 1b6ec8b [FrameworkBundle] add cache.app.simple psr simple cache
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a PSR SimpleCache version of the
cache.appservice.Should I also update the documentation somewhere? 😊