[TwigBridge] Allow label translation to be safe #25744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guess I'll have to override the form theme. |
|
Well I'd like to hear something though. |
|
Ping @nicolas-grekas you're the only one who interacted with this PR. |
nicolas-grekas
approved these changes
Jan 30, 2018
fabpot
approved these changes
Jan 30, 2018
|
Thank you @MatTheCat. |
fabpot
added a commit
that referenced
this pull request
Jan 30, 2018
This PR was merged into the 2.7 branch.
Discussion
----------
[TwigBridge] Allow label translation to be safe
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | ~
| Fixed tickets | ~
| License | MIT
| Doc PR | ~
After overriding `TranslationExtension`'s `trans` filter to make it safe I noticed form labels were still escaped because of `label` in
```twig
{{ translation_domain is same as(false) ? label : label|trans({}, translation_domain) }}
```
Replacing this ternary with `if`/`else` allows `trans` return to be safe.
WDYT?
Commits
-------
041c42d Allow trans filter to be safe
This was referenced Feb 28, 2018
Closed
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After overriding
TranslationExtension'stransfilter to make it safe I noticed form labels were still escaped because oflabelin{{ translation_domain is same as(false) ? label : label|trans({}, translation_domain) }}Replacing this ternary with
if/elseallowstransreturn to be safe.WDYT?