[HttpKernel] Turn bad hosts into 400 instead of 500 #25750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jan 10, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
Definitely makes sense 👍 |
fabpot
approved these changes
Jan 10, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 10, 2018
…as-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] Turn bad hosts into 400 instead of 500 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 3e47c71 [HttpKernel] Turn bad hosts into 400 instead of 500
lyrixx
reviewed
Jan 11, 2018
| /** | ||
| * @expectedException \Symfony\Component\HttpKernel\Exception\BadRequestHttpException | ||
| */ | ||
| public function testSubRequestWithBadHost() |
There was a problem hiding this comment.
It's not about sub request. But master request
There was a problem hiding this comment.
"Sub" removed, thanks
There was a problem hiding this comment.
oups, it's already merged :) PR welcome then :P
nicolas-grekas
added a commit
that referenced
this pull request
Jan 11, 2018
This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] Fixed test name | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25750 (comment) | License | MIT | Doc PR | Commits ------- e366772 [HttpKernel] Fixed test name
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.