[Validator] 19 digits VISA card numbers are valid #25771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jan 11, 2018
dbrumann
reviewed
Jan 11, 2018
| @@ -81,7 +81,7 @@ class CardSchemeValidator extends ConstraintValidator | |||
| ), | |||
| // All Visa card numbers start with a 4. New cards have 16 digits. Old cards have 13. | |||
There was a problem hiding this comment.
Comment should be removed or updated as well?
javiereguiluz
approved these changes
Jan 12, 2018
There was a problem hiding this comment.
@xabbuh thank you for fixing this error. Please, don't forget to update the comment too. Thanks!
Simperfit
approved these changes
Jan 12, 2018
9765fd1 to
a53cc5c
Compare
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 13, 2018
This PR was merged into the 2.7 branch. Discussion ---------- [Validator] 19 digits VISA card numbers are valid | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | some sources: * https://en.wikipedia.org/wiki/Payment_card_number * https://blog.vindicia.com/19-digit-visas-and-2-digit-mastercards/ * https://www.nccgroup.trust/de/uber-uns/newsroom-and-events/blogs/2016/november/prepare-for-19-digit-credit-cards/ * http://support.worldpay.com/support/kb/bg/testandgolive/tgl5103.html Commits ------- a53cc5c 19 digits VISA card numbers are valid
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some sources: