[Router] Skip anonymous classes when loading annotated routes #25801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e016c78 to
91c878e
Compare
e6cb583 to
3a272b2
Compare
| // Skip usage of ::class constant | ||
| $isClassConstant = false; | ||
| // Skip usage of ::class constant and anonymous classes | ||
| $isValidClass = true; |
There was a problem hiding this comment.
Not sure about this variable name -> $isValidClass because an anonymous class is a valid class.
There was a problem hiding this comment.
I was mostly trying to avoid using isClassConstantOrAnonymousClass and isValidClass is the first thing that came to mind. I'll change it to something more reasonable
stof
approved these changes
Jan 16, 2018
javiereguiluz
approved these changes
Jan 16, 2018
xabbuh
approved these changes
Jan 16, 2018
|
Thank you @pierredup. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 16, 2018
…tes (pierredup) This PR was squashed before being merged into the 2.7 branch (closes #25801). Discussion ---------- [Router] Skip anonymous classes when loading annotated routes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25796 | License | MIT | Doc PR | Skip any usage of anonymous classes when parsing files in `AnnotationFileLoader` Commits ------- d76a545 [Router] Skip anonymous classes when loading annotated routes
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip any usage of anonymous classes when parsing files in
AnnotationFileLoader