[HttpKernel] DebugHandlersListener should always replace the existing exception handler #25835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the scenario in prod mode with both the exception and error handlers pre-set, awesome! ❤️ |
45121bd to
a8dc27b
Compare
chalasr
approved these changes
Jan 18, 2018
b6fc69e to
0c0dd33
Compare
… exception handler
0c0dd33 to
a4ddcc2
Compare
|
HHVM failure fixed by adding a new exclusion group, to allow easily reproducing the issue while facebook/hhvm#8107 is open. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 18, 2018
…he existing exception handler (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] DebugHandlersListener should always replace the existing exception handler | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25827 | License | MIT | Doc PR | - The current logic is inconsistent because replacing or not depends whether an ExceptionHandler is registered or not. Embeds tests for the previous PR on the same topic, Debug component's side. Commits ------- a4ddcc2 [HttpKernel] DebugHandlersListener should always replace the existing exception handler
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic is inconsistent because replacing or not depends whether an ExceptionHandler is registered or not.
Embeds tests for the previous PR on the same topic, Debug component's side.