[HttpKernel] Make session-related services extra-lazy #25836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jan 18, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
5a9272e to
fa4864a
Compare
chalasr
reviewed
Jan 18, 2018
| { | ||
| $this->container = $container; | ||
| } | ||
|
|
||
| protected function getSession() | ||
| { | ||
| if (!$this->container->has('session')) { |
There was a problem hiding this comment.
$this->container can be null now
There was a problem hiding this comment.
good catch, fixed
f7ae524 to
8600644
Compare
8600644 to
5f53558
Compare
chalasr
approved these changes
Jan 20, 2018
fabpot
reviewed
Jan 23, 2018
| @@ -22,8 +22,6 @@ | |||
| */ | |||
| class SessionListener extends AbstractSessionListener | |||
| { | |||
| private $container; | |||
|
|
|||
There was a problem hiding this comment.
moved to the parent
fabpot
approved these changes
Jan 23, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 23, 2018
…(nicolas-grekas) This PR was merged into the 4.1-dev branch. Discussion ---------- [HttpKernel] Make session-related services extra-lazy | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 5f53558 [HttpKernel] Make session-related services extra-lazy
Merged
Nyholm
added a commit
that referenced
this pull request
Oct 30, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Remove Symfony 3 compatibility code | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #38892 | License | MIT | Doc PR | N/A This PR removes dead code that checks for the presence of the `Request::setSessionFactory()` method. That method was added with #25836 in HttpFoundation 4.1. Since HttpKernel requires at least HttpFoundation 4.4, we can assume that the method is always present and thus simplify some code here. Additionally, I also fix the doc block as described in #38892. 😉 Commits ------- b9ca866 Remove Symfony 3 compatibility code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.