Skip to content

[SecurityBundle] Deprecate in_memory.user abstract service #25839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jan 18, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #25837 (comment)
License MIT
Doc PR n/a

@fabpot
Copy link
Member

fabpot commented Jan 19, 2018

Apparently, tests do not pass.

@chalasr chalasr force-pushed the deprec-user-service branch from 6ec1b6e to 395a0f0 Compare January 19, 2018 09:42
@chalasr chalasr force-pushed the deprec-user-service branch from 395a0f0 to 75a4117 Compare January 19, 2018 11:36
@chalasr
Copy link
Member Author

chalasr commented Jan 19, 2018

@fabpot #25837 has been merged up to master, now green

@fabpot
Copy link
Member

fabpot commented Jan 19, 2018

Thank you @chalasr.

@fabpot fabpot merged commit 75a4117 into symfony:master Jan 19, 2018
fabpot added a commit that referenced this pull request Jan 19, 2018
…vice (chalasr)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[SecurityBundle] Deprecate in_memory.user abstract service

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #25837 (comment)
| License       | MIT
| Doc PR        | n/a

Commits
-------

75a4117 [SecurityBundle] Deprecate in_memory.user abstract service
@chalasr chalasr deleted the deprec-user-service branch January 19, 2018 12:03
@fabpot fabpot mentioned this pull request May 7, 2018
nicolas-grekas added a commit that referenced this pull request Nov 7, 2019
…cyweb)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[SecurityBundle] Remove deprecated service and code

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Remove deprecated service in #25839 and deprecated code in #33676.

Commits
-------

ad61d6f [SecurityBundle] Remove deprecated service and code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants