[DoctrineBridge] Fix bug when indexBy is meta key in PropertyInfo\DoctrineExtractor #25841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@insekticid would you mind adding a test case please? Status: needs work |
|
@insekticid Can you work on adding a test case for your bug fix? That's something we need to avoid future regression. Or do you need help? |
|
Status: needs work |
|
I need some time to go back to this issue and write some tests |
05a9d10 to
fb8fe4b
Compare
|
added tests @dunglas ping |
|
Travis failure is unrelated. Status: Needs Review |
dunglas
approved these changes
Apr 9, 2018
nicolas-grekas
approved these changes
Apr 14, 2018
|
Isn't it something that also needs to be fixed in 2.8? |
|
Thank you @insekticid. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 20, 2018
…rtyInfo\DoctrineExtractor (insekticid) This PR was submitted for the 3.4 branch but it was merged into the 2.8 branch instead (closes #25841). Discussion ---------- [DoctrineBridge] Fix bug when indexBy is meta key in PropertyInfo\DoctrineExtractor | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #25834 <!-- #-prefixed issue number(s), if any --> | License | MIT @dunglas could you check it? <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Replace this comment by a description of what your PR is solving. --> Commits ------- 583759f PropertyInfo\DoctrineExtractor - There is bug when indexBy is meta key
This was referenced Apr 30, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dunglas could you check it?