[Validator] Conflict with egulias/email-validator 2.0 #25851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jan 20, 2018
|
Thank you @emodric. |
fabpot
added a commit
that referenced
this pull request
Jan 20, 2018
…dric) This PR was merged into the 2.7 branch. Discussion ---------- [Validator] Conflict with egulias/email-validator 2.0 | Q | A | ------------- | --- | Branch? | 2.7 (and 2.8) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A For code that uses `EmailValidator` with strict email checking using `egulias/email-validator` and that aims to support both Symfony 2.8 LTS and Symfony 3.4/4.0, it is impossible to have a working set of dependencies with Symfony 2.7/Symfony 2.8 if one wishes to use `egulias/email-validator: ^1.2|^2.1`. This is because Composer happily installs `egulias/email-validator` latest 2.1.x which is not compatible with Symfony 2.8. This would prevent installation of v2.1.x on Symfony 2.7/2.8. Commits ------- 72d8e8a [Validator] Conflict with egulias/email-validator 2.0
|
This does not look like a good idea to me. It will break all existing applications (i.e. preventing them to update) if they make use of version 2.0 of the email address validator library (for example, they use a custom validation validation constraint). |
|
@xabbuh Oh, that actually makes sense! Sorry for the confusion! |
|
reverted in #25861 |
fabpot
added a commit
that referenced
this pull request
Jan 21, 2018
This PR was merged into the 2.7 branch. Discussion ---------- do not conflict with egulias/email-validator 2.0+ | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25851 (comment) | License | MIT | Doc PR | Not allowing `egulias/email-validator` 2.0+ will prevent applications using this package from updating to the next patch release. Commits ------- 1a1aaa7 Revert "bug #25851 [Validator] Conflict with egulias/email-validator 2.0 (emodric)"
nicolas-grekas
added a commit
that referenced
this pull request
Jan 21, 2018
* 2.7: [HttpFoundation] fixed return type of method HeaderBag::get [HttpFoundation] Added "resource" type on Request::create docblock Revert "bug #25789 Enableable ArrayNodeDefinition is disabled for empty configuration (kejwmen)" Revert "bug #25851 [Validator] Conflict with egulias/email-validator 2.0 (emodric)" [Validator] add missing parent isset and add test
nicolas-grekas
added a commit
that referenced
this pull request
Jan 21, 2018
* 2.8: [HttpFoundation] fixed return type of method HeaderBag::get [HttpFoundation] Added "resource" type on Request::create docblock Revert "bug #25789 Enableable ArrayNodeDefinition is disabled for empty configuration (kejwmen)" Formatting fix in upgrade 3.0 document Revert "bug #25851 [Validator] Conflict with egulias/email-validator 2.0 (emodric)" [Validator] add missing parent isset and add test
nicolas-grekas
added a commit
that referenced
this pull request
Jan 21, 2018
* 3.3: Have weak_vendors ignore deprecations from outside [HttpFoundation] fixed return type of method HeaderBag::get [HttpFoundation] Added "resource" type on Request::create docblock [Process] Skip environment variables with false value in Process Revert "bug #25789 Enableable ArrayNodeDefinition is disabled for empty configuration (kejwmen)" Formatting fix in upgrade 3.0 document don't split lines on carriage returns when dumping Revert "bug #25851 [Validator] Conflict with egulias/email-validator 2.0 (emodric)" [DI] compilation perf tweak [Validator] Conflict with egulias/email-validator 2.0 [Validator] add missing parent isset and add test
nicolas-grekas
added a commit
that referenced
this pull request
Jan 21, 2018
* 3.4: Have weak_vendors ignore deprecations from outside [HttpFoundation] fixed return type of method HeaderBag::get [HttpFoundation] Added "resource" type on Request::create docblock [Process] Skip environment variables with false value in Process Revert "bug #25789 Enableable ArrayNodeDefinition is disabled for empty configuration (kejwmen)" Formatting fix in upgrade 3.0 document don't split lines on carriage returns when dumping Revert "bug #25851 [Validator] Conflict with egulias/email-validator 2.0 (emodric)" [DI] compilation perf tweak [Validator] Conflict with egulias/email-validator 2.0 [Validator] add missing parent isset and add test
nicolas-grekas
added a commit
that referenced
this pull request
Jan 21, 2018
* 4.0: Have weak_vendors ignore deprecations from outside [HttpFoundation] fixed return type of method HeaderBag::get [HttpFoundation] Added "resource" type on Request::create docblock [Console] Fix using finally where the catch can also fail [Process] Skip environment variables with false value in Process Revert "bug #25789 Enableable ArrayNodeDefinition is disabled for empty configuration (kejwmen)" Formatting fix in upgrade 3.0 document don't split lines on carriage returns when dumping trim spaces from unquoted scalar values Revert "bug #25851 [Validator] Conflict with egulias/email-validator 2.0 (emodric)" [DI] compilation perf tweak [Validator] Conflict with egulias/email-validator 2.0 [Validator] add missing parent isset and add test
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code that uses
EmailValidatorwith strict email checking usingegulias/email-validatorand that aims to support both Symfony 2.8 LTS and Symfony 3.4/4.0, it is impossible to have a working set of dependencies with Symfony 2.7/Symfony 2.8 if one wishes to useegulias/email-validator: ^1.2|^2.1.This is because Composer happily installs
egulias/email-validatorlatest 2.1.x which is not compatible with Symfony 2.8.This would prevent installation of v2.1.x on Symfony 2.7/2.8.