[Process] Skip environment variables with false value in Process #25869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -331,7 +331,9 @@ public function start(callable $callback = null/*, array $env = array()*/) | |||
| } else { | |||
| $envPairs = array(); | |||
| foreach ($env as $k => $v) { | |||
| $envPairs[] = $k.'='.$v; | |||
| if (is_string($v)) { | |||
There was a problem hiding this comment.
Should be more specific IMHO. Eg numbers should not be filtered. false !== ?
There was a problem hiding this comment.
Initially, this is the test I did to fix the problem, but after, I saw the test in the getDefaultEnv() method. I also prefer to use false !== because it is more specific. I change that immediately.
|
@nicolas-grekas It's updated. |
nicolas-grekas
approved these changes
Jan 21, 2018
|
Thank you @francoispluchino. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 21, 2018
…rocess (francoispluchino) This PR was merged into the 3.3 branch. Discussion ---------- [Process] Skip environment variables with false value in Process | Q | A | ------------- | --- | Branch? | master, 4.0, 3.3, 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ With the commit 03adce2, all env variables are injecting in the process, and the env variable with the `false` value are converted in empty string. For example, it's problematic with the bundle SymfonyWebServerBundle and the last version of the [symfony/framework-bundle recipe](https://github.com/symfony/recipes/blob/master/symfony/framework-bundle/3.3/public/index.php#L11), because the WebServer override the value of `APP_ENV` with `false` to override previously loaded variables (c5a1218), and with the commit 03adce2, the `APP_ENV` variable is injected with a empty string value, instead of not being injected, as was the case before. This PR not use the same logic as the [getDefaultEnv()](https://github.com/symfony/symfony/blob/4.0/src/Symfony/Component/Process/Process.php#L1553) method. Commits ------- 2daf4f9 [Process] Skip environment variables with false value in Process
|
@nicolas-grekas It's always a pleasure to help. |
This was referenced Jan 29, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the commit 03adce2, all env variables are injecting in the process, and the env variable with the
falsevalue are converted in empty string.For example, it's problematic with the bundle SymfonyWebServerBundle and the last version of the symfony/framework-bundle recipe, because the WebServer override the value of
APP_ENVwithfalseto override previously loaded variables (c5a1218), and with the commit 03adce2, theAPP_ENVvariable is injected with a empty string value, instead of not being injected, as was the case before.This PR not use the same logic as the getDefaultEnv() method.