Adding an array adapter #25892
Merged
Adding an array adapter #25892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
approved these changes
Jan 23, 2018
xabbuh
reviewed
Jan 23, 2018
| <tag name="cache.pool" clearer="cache.default_clearer" /> | ||
| <tag name="monolog.logger" channel="cache" /> | ||
| <argument>0</argument> <!-- default lifetime --> | ||
| <call method="setLogger"> |
There was a problem hiding this comment.
There is no setLogger() method in ArrayAdapter, is there?
never mind, it is, ArrayAdapter uses ArrayTrait which in turn uses LoggerAwareTrait
xabbuh
approved these changes
Jan 23, 2018
dunglas
approved these changes
Jan 23, 2018
javiereguiluz
approved these changes
Jan 24, 2018
|
did you test it? |
|
Yes, tested in a real project! And you're right about the ArrayAdapter argument thing, but it was already taken into account: |
Why not using |
|
Thank you @weaverryan. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 31, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- Adding an array adapter | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | symfony/symfony-docs#9110 There's no simple way to *disable* caching (e.g. in the dev) environment. Setting up an array adapter is a very simple way to allow this :). Commits ------- f92e03d adding an array adapter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no simple way to disable caching (e.g. in the dev) environment. Setting up an array adapter is a very simple way to allow this :).