Skip to content

[Form] Deprecate a callable empty_data in ChoiceType #25924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[Form] Deprecate a callable empty_data in ChoiceType #25924

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
96e194c
Merge pull request #1 from symfony/master
peter-gribanov Jan 23, 2018
b8ac58c
mark usage of callable empty_data not instance of \Closure is deprecated
peter-gribanov Jan 25, 2018
f8cc144
allow use array as handler
peter-gribanov Jan 25, 2018
62d2c14
add info in UPGRADE and CHANGELOG. Add callable empty_data tests
peter-gribanov Jan 25, 2018
da3c6ac
fix CS
peter-gribanov Jan 25, 2018
db28aef
use a global function in examples
peter-gribanov Jan 25, 2018
734fce1
change description of this change in UPGRADE-5.0.md
peter-gribanov Jan 25, 2018
3d19d31
change description of this change in UPGRADE-4.1.md
peter-gribanov Jan 25, 2018
6173596
change description of this change in CHANGELOG.md
peter-gribanov Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix CS
  • Loading branch information
@peter-gribanov
peter-gribanov committed Jan 25, 2018
commit da3c6acddbc71e23fbc51f76df402cda71677dab
2 changes: 1 addition & 1 deletion src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ public function testSubmitSingleChoiceWithClosureEmptyData()
'multiple' => false,
'expanded' => true,
'choices' => array('test'),
'empty_data' => function() {
'empty_data' => function () {
return 'test';
},
));
Expand Down