[Form] keep the context when validating forms #25940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 26, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25542 |
| License | MIT |
| Doc PR |
|
The context is modified by the nested validator calls for the form children. I am actually not sure if this solution is the best or if we should rather clone the current context before validating the nested data. If someone is able to write a test case for this, that will be really appreciated. I failed miserably. |
|
Status: Needs Review |
|
|
nicolas-grekas
approved these changes
Feb 3, 2018
fabpot
approved these changes
Feb 7, 2018
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 7, 2018
This PR was merged into the 2.7 branch. Discussion ---------- [Form] keep the context when validating forms | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25542 | License | MIT | Doc PR | Commits ------- 317da3b keep the context when validating forms
This was referenced Feb 28, 2018
Closed
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.