Always show all deprecations except legacy ones when not weak #25997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c16a35a to
abc2e37
Compare
abc2e37 to
e5928c2
Compare
| @@ -165,13 +165,13 @@ public static function register($mode = 0) | |||
|
|
|||
| exit(1); | |||
| } | |||
| if ('legacy' !== $group && !$isWeak) { | |||
There was a problem hiding this comment.
the $isWeak variable is not used anymore, isn't it ?
There was a problem hiding this comment.
That's right, good riddance!
There was a problem hiding this comment.
but now $isVendor is always false and $inVendors is never called :)
There was a problem hiding this comment.
I spotted and pushed again yeah :P should have checked the tests before pushing 😅
993980b to
4af68d9
Compare
| @@ -111,7 +111,7 @@ public static function register($mode = 0) | |||
| $trace = debug_backtrace(true); | |||
| $group = 'other'; | |||
| $isVendor = false; | |||
| $isWeak = DeprecationErrorHandler::MODE_WEAK === $mode || (DeprecationErrorHandler::MODE_WEAK_VENDORS === $mode && $isVendor = $inVendors($file)); | |||
| $isVendor = $inVendors($file); | |||
There was a problem hiding this comment.
$isVendor = DeprecationErrorHandler::MODE_WEAK_VENDORS === $mode && ... (same below, so that we don't compute $isVendor when not needed, isn't it?)
There was a problem hiding this comment.
Yeah plus I have 2 $isVendor assignments now 😅
There was a problem hiding this comment.
The condition on line 147 can go
4af68d9 to
d7b0236
Compare
| ----- | ||
|
|
||
| * all deprecations but those from tests marked with `@group legacy` are always | ||
| displayed, regardless of the mode. |
When using any mode but the weak mode, you want your build to fail on some or all deprecations, but it is still nice to be able to see what you could fix without having to change modes.
d7b0236 to
9e37873
Compare
nicolas-grekas
approved these changes
Feb 4, 2018
fabpot
approved these changes
Feb 7, 2018
|
Thank you @greg0ire. |
fabpot
added a commit
that referenced
this pull request
Feb 7, 2018
…ot weak (greg0ire) This PR was merged into the 4.1-dev branch. Discussion ---------- Always show all deprecations except legacy ones when not weak When using any mode but the weak mode, you want your build to fail on some or all deprecations, but it is still nice to be able to see what you could fix without having to change modes. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Replace this comment by a description of what your PR is solving. --> Commits ------- 9e37873 Always show all deprecations except legacy ones
nicolas-grekas
added a commit
that referenced
this pull request
Feb 11, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Feb 11, 2018
* 3.4: [Bridge/PhpUnit] Fix tests by backporting #25997 to 3.4
nicolas-grekas
added a commit
that referenced
this pull request
Feb 11, 2018
* 4.0: [Bridge/PhpUnit] Fix tests by backporting #25997 to 3.4
|
FYI, this PR has been backported to 3.4 in 9a9c0f6. There is now way to make tests pass otherwise, since this changes the behavior. |
Merged
greg0ire
added a commit
to greg0ire/symfony
that referenced
this pull request
Jul 23, 2018
The behavior has changed since symfony#25997
greg0ire
added a commit
to greg0ire/symfony
that referenced
this pull request
Jul 23, 2018
The behavior has changed since symfony#25997
greg0ire
added a commit
to greg0ire/symfony
that referenced
this pull request
Jul 23, 2018
The behavior has changed since symfony#25997
greg0ire
added a commit
to greg0ire/symfony
that referenced
this pull request
Jul 23, 2018
The behavior has changed since symfony#25997
nicolas-grekas
added a commit
that referenced
this pull request
Jul 25, 2018
This PR was squashed before being merged into the 4.1 branch (closes #28046). Discussion ---------- [PhpUnitBridge] Describe weak_vendors properly | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The `weak_vendors` mode now displays deprecations, this behavior has changed since #25997 Commits ------- 336008c [PhpUnitBridge] Describe weak_vendors properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using any mode but the weak mode, you want your build to fail on some or
all deprecations, but it is still nice to be able to see what you could
fix without having to change modes.