[SecurityBundle] use libsodium to run Argon2i related tests #26057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 5, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26038 |
| License | MIT |
| Doc PR |
.travis.yml
Outdated
| # install libsodium | ||
| - sudo add-apt-repository ppa:ondrej/php -y | ||
| - sudo apt-get update -q | ||
| - sudo apt-get install libsodium-dev -y |
There was a problem hiding this comment.
I'd suggest to move these 3 lines below Install extra PHP extensions, in the same block (no dashes before)
There was a problem hiding this comment.
oh, and move them in the "elif" below, and wrap them in another "if" that checks if the sodium.so exists in the cache already or not (see tpecl)
chalasr
approved these changes
Feb 5, 2018
| @@ -149,7 +149,13 @@ before_install: | |||
| ([[ $deps ]] || tfold ext.symfony_debug 'cd src/Symfony/Component/Debug/Resources/ext && phpize && ./configure && make && echo extension = $(pwd)/modules/symfony_debug.so >> '"$INI") | |||
| tfold ext.apcu tpecl apcu-4.0.11 apcu.so | |||
| elif [[ ! $skip && $PHP = 7.* ]]; then | |||
| # install libsodium | |||
There was a problem hiding this comment.
if [[ ! -e ~/php-ext/$(php -r "echo basename(ini_get('extension_dir'));")/libsodium/sodium.so ]]; then
nicolas-grekas
approved these changes
Feb 6, 2018
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 6, 2018
…s (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] use libsodium to run Argon2i related tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26038 | License | MIT | Doc PR | Commits ------- 5f9471e use libsodium to run Argon2i related tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.