[HttpKernel] Make kernel build time optionally deterministic #26128
Conversation
| @@ -717,6 +717,7 @@ protected function getKernelParameters() | |||
| 'kernel.bundles_metadata' => $bundlesMetadata, | |||
| 'kernel.charset' => $this->getCharset(), | |||
| 'kernel.container_class' => $this->getContainerClass(), | |||
| 'kernel.container_build_time' => time(), | |||
There was a problem hiding this comment.
Wait, this doesn't work: before this change, the container had always the same hash, thus was stored always in the same dir. Now that this param is time dependent - and since it's dumped into the container, this property is broken.
There was a problem hiding this comment.
Do you mean because kernel.container_build_time will be different for every request? That is indeed true but it’s only used in the dumper.
There was a problem hiding this comment.
Yes, that's what I mean.
There was a problem hiding this comment.
Changed it to just introduce a method that returns the build time. People who want to make it deterministic can hook their own getenv() magic in there.
| @@ -855,6 +855,7 @@ protected function dumpContainer(ConfigCache $cache, ContainerBuilder $container | |||
| 'as_files' => true, | |||
| 'debug' => $this->debug, | |||
| 'inline_class_loader_parameter' => \PHP_VERSION_ID >= 70000 && !$this->loadClassCache && !class_exists(ClassCollectionLoader::class, false) ? 'container.dumper.inline_class_loader' : null, | |||
| 'build_time' => $this->getContainerBuildTime(), | |||
There was a problem hiding this comment.
instead of the method, what about adding the option only when a kernel.container_build_time parameter exists?
|
Thank you @lstrojny. |
This PR was merged into the 3.4 branch. Discussion ---------- Make kernel build time optionally deterministic | Q | A | ------------- | --- | Branch? | master for features / 2.7 up to 4.0 for bug fixes <!-- see below --> | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As part of the effort to enable reproducible builds, this PR allows setting a deterministic build time for the dumped kernel. Parent issue is #25958. Commits ------- 48e8249 Make kernel build time optionally deterministic
As part of the effort to enable reproducible builds, this PR allows setting a deterministic build time for the dumped kernel. Parent issue is #25958.