[PHPUnit bridge] Avoid running the remove command without any packages #26170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the exit code of the command was not checked, the failure was not breaking things, but it was still printing a confusing error message.
nicolas-grekas
approved these changes
Feb 14, 2018
|
Thank you @stof. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 14, 2018
…any packages (stof) This PR was merged into the 3.4 branch. Discussion ---------- [PHPUnit bridge] Avoid running the remove command without any packages | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | n/a | License | MIT | Doc PR | n/a As the exit code of the command was not checked, the failure was not breaking things, but it was still printing a confusing error message. This does not apply to versions older than 3.4, as it was impossible to set `SYMFONY_PHPUNIT_REMOVE` to an empty string before (it was applying the default removing rules instead in such case) Commits ------- 34d2781 Avoid running the remove command without any packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the exit code of the command was not checked, the failure was not breaking things, but it was still printing a confusing error message.
This does not apply to versions older than 3.4, as it was impossible to set
SYMFONY_PHPUNIT_REMOVEto an empty string before (it was applying the default removing rules instead in such case)