[FrameworkBundle] Add support to 307/308 HTTP status codes in RedirectController #26213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
requested changes
Feb 18, 2018
| * | ||
| * @throws HttpException In case the route name is empty | ||
| */ | ||
| public function redirectAction(Request $request, string $route, bool $permanent = false, $ignoreAttributes = false): Response | ||
| public function redirectAction(Request $request, string $route, bool $permanent = false, $ignoreAttributes = false, bool $keepRequestMethod = false): Response |
There was a problem hiding this comment.
for other reviewers: the class is final, so this is not a BC break
| { | ||
| if ('' == $route) { | ||
| throw new HttpException($permanent ? 410 : 404); | ||
| throw new HttpException($permanent ? Response::HTTP_GONE : Response::HTTP_NOT_FOUND); |
There was a problem hiding this comment.
we prefer explicit numbers; please revert, and use numbers everywhere in the PR
There was a problem hiding this comment.
@nicolas-grekas Change reverted
nicolas-grekas
approved these changes
Feb 18, 2018
fabpot
approved these changes
Feb 19, 2018
|
Thank you @ZipoKing. |
fabpot
added a commit
that referenced
this pull request
Feb 19, 2018
…odes in RedirectController (ZipoKing) This PR was squashed before being merged into the 4.1-dev branch (closes #26213). Discussion ---------- [FrameworkBundle] Add support to 307/308 HTTP status codes in RedirectController | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26171 | License | MIT | Doc PR | With this PR `RedirectController` will allow to create redirections with use of 307/308 HTTP status codes together with 301/302. Related RFC documents: * https://tools.ietf.org/html/rfc7231 * https://tools.ietf.org/html/rfc7538 Commits ------- 64fb5a5 [FrameworkBundle] Add support to 307/308 HTTP status codes in RedirectController
|
this needs a documentation PR though |
|
@stof will prepare some docs PR later today |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 5, 2018
…7/308 HTTP status codes (ZipoKing, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle] PR #26213 Document redirections with 307/308 HTTP status codes This documents changes introduced with pull request symfony/symfony#26213 Commits ------- 9468bf9 Reword and added an example c8ce65d Changes after @Simperfit review b3984d0 [PR #26213 Document redirections with 307/308 HTTP status codes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR
RedirectControllerwill allow to create redirections with use of 307/308 HTTP status codes together with 301/302. Related RFC documents: