Skip to content

[FrameworkBundle] Fix deprecation message format #26221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FrameworkBundle] Fix deprecation message format #26221

wants to merge 1 commit into from

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Feb 19, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25456 (comment)
License MIT
Doc PR symfony/symfony-docs#...

missed the memo :)

@@ -13,14 +13,14 @@

use Symfony\Component\HttpKernel\DataCollector\RequestDataCollector as BaseRequestDataCollector;

@trigger_error(sprintf('The "%s" class is deprecated since version 4.1 and will be removed in Symfony 5.0. Use %s instead.', RequestDataCollector::class, BaseRequestDataCollector::class), E_USER_DEPRECATED);
@trigger_error(sprintf('The "%s" class is deprecated since version Symfony 4.1 and will be removed in 5.0. Use %s instead.', RequestDataCollector::class, BaseRequestDataCollector::class), E_USER_DEPRECATED);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since version Symfony 4.1 (same below)

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Feb 19, 2018
@nicolas-grekas
Copy link
Member

Closing in favor of #26225, thanks anyway :)

@ro0NL ro0NL deleted the deprecation branch February 19, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants