[WebProfilerBundle] Fix anchor CSS #26230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does the anchor still work as expected ? ie anchoring to line 100 should create a top screen margin so that L100 is not hidden on the top of the screen, but has some offset before |
|
you're right. Not sure what the quirk is but it needs to be a block element indeed. Using
For But now there's this random space in both chrome and firefox:
Guess it's comes from a line break in source:
Can have a look at that.. but maybe some real CSS expert knows a better fix. |
|
Now all good :) |
nicolas-grekas
approved these changes
Feb 19, 2018
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 19, 2018
This PR was squashed before being merged into the 3.4 branch (closes #26230). Discussion ---------- [WebProfilerBundle] Fix anchor CSS | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Empty source lines overlap in `/_profiler/open?file=x`. AFAIK it's a regression after #23296, but it's the first time i noticed so maybe it's related to a chrome change in between. No real CSS expert.. but this seems to fix it. Before:  After:  I can confirm both chrome and firefox render as shown in the after screenshot. Firefox worked before as well, chrome not. cc @ogizanagi Commits ------- ee45992 [WebProfilerBundle] Fix anchor CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty source lines overlap in
/_profiler/open?file=x. AFAIK it's a regression after #23296, but it's the first time i noticed so maybe it's related to a chrome change in between. No real CSS expert.. but this seems to fix it.Before:
After:
I can confirm both chrome and firefox render as shown in the after screenshot. Firefox worked before as well, chrome not.
cc @ogizanagi