fix custom radios/inputs for checkbox/radio type #26254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiot
approved these changes
Feb 21, 2018
|
It's ok for me :) |
|
Excellent Marek. Thank you. Could you make a small update PR to the from here: https://github.com/Nyholm/symfony-bootstrap-form/blob/master/src/Form/SuperFormType.php I want to see the difference of the output. |
|
@Nyholm that form is shared with several css frameworks, this feature is specific for bootstrap 4, should I rly submit PR? |
|
Yes please. Im not really sure what a custom radio is to be honest. |
|
It's just a different CSS applied on a checkbox or a radio in the bootstrap
4 framework. It does a nice box/radio.
|
|
Thank you @mssimi. |
fabpot
added a commit
that referenced
this pull request
Feb 21, 2018
This PR was merged into the 3.4 branch. Discussion ---------- fix custom radios/inputs for checkbox/radio type | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | | Fixed tickets | #25715 | License | MIT | Doc PR | Hey, I tried new changes in bootstrap 4 layout. Unfortunatelly custom-radios/checkboxes seems to work only for ChoiceType/EntityType but not for CheckboxType/RadioType. I added changes which I belive fix this issue. Commits ------- dd6d1dd fix custom radios/inputs for checkbox/radio type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I tried new changes in bootstrap 4 layout. Unfortunatelly custom-radios/checkboxes seems to work only for ChoiceType/EntityType but not for CheckboxType/RadioType. I added changes which I belive fix this issue.